Improve alignment exception error reporting#399
Merged
pmachapman merged 1 commit intomasterfrom Mar 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 72.79% 72.78% -0.02%
==========================================
Files 424 424
Lines 36309 36314 +5
Branches 5006 5006
==========================================
Hits 26431 26431
- Misses 8770 8775 +5
Partials 1108 1108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
approved these changes
Mar 26, 2026
Contributor
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
Enkidu93
approved these changes
Mar 26, 2026
Collaborator
Enkidu93
left a comment
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of sillsdev/serval#893, this PR improves error reporting to give details on the
ArgumentExceptionthat caused theCorpusAlignmentException, and fixes aNullReferenceExceptionwhen one of the rows referenced in theCorpusAlignmentExceptionisnull.This change is